0000287: conflicted selector always selects all files

Viewing Issue Simple Details [ Jump to Notes ]

[ View Advanced ] [ Issue History ] [ Print ]

Category

Severity

Reproducibility

Date Submitted

Last Update

0000287

[SVNKit] bug

major

always

2008-12-01 07:29

2008-12-05 21:06

Reporter

jfrank

View Status

public

Assigned To

oka

Priority

normal

Resolution

fixed

Status

resolved

Product Version

1.2.x

Summary

0000287: conflicted selector always selects all files

Description

I am the svnant maintainer from subclipse, which is a client of your library.

I have a test that is publicly available subversion checkout:

http://subclipse.tigris.org/svn/subclipse/trunk/svnant [^]

org.tigris.subversion.svnant.SvnSvnKitTest.testConflictedSelector()

The gist of the test is this, from ant we select conflicted files from a directory, and move them to a temporary location. It selects all the files, not the two that are conflicted, and the test fails.

The other clients (javaHL and commandline) don't fail.

AFAIK the underlying cause is that svnkit fills in a value in Status that is later returned by getConflictWorking() on every file, regardless of actual status. The other implementations return null, the null is passed down to mean 'not selected' in svnant. I am getting a value from svnkit for every file in the directory for getConflictWorking.

Please advise...

Additional Information

using 1.2 rev 4949

Tags

No tags attached.

planned for version

1.2.x

Attached Files

Relationships

Notes
(0000556) oka (administrator) 2008-12-05 21:06	Thank you for reporting this issue. It is now fixed in 1.2.x and trunk branches of SVNKit. The reason of the problem was that Status.conflict* fields were set to empty string instead of null when there were no conflict files.

Issue History
Date Modified	Username	Field	Change
2008-12-01 07:30	jfrank	New Issue
2008-12-05 00:14	oka	Status	new => assigned
2008-12-05 00:14	oka	Assigned To	=> oka
2008-12-05 21:06	oka	planned for version	=> 1.2.x
2008-12-05 21:06	oka	Note Added: 0000556
2008-12-05 21:06	oka	Status	assigned => resolved
2008-12-05 21:06	oka	Resolution	open => fixed
2008-12-05 21:06	oka	Fixed in Version	=> 1.2.2

Mantis 1.1.0[^]